Skip to content

Feature/greenhouse fix#256

Merged
iruzevic merged 14 commits into
developfrom
feature/greenhouse-fix
Sep 7, 2022
Merged

Feature/greenhouse fix#256
iruzevic merged 14 commits into
developfrom
feature/greenhouse-fix

Conversation

@iruzevic
Copy link
Copy Markdown
Member

@iruzevic iruzevic commented Sep 2, 2022

Description

Added

  • custom form params are now in one place and used as a enum for PHP and JS.
  • server errors will no longer produce fatal error on the form but will output the msg to the user, and the msg is also translatable.
  • option to remove all unnecessary custom params that are set on the form before the final integration post so we don't send unnecessary stuff.
  • new admin setting sidebar title for grouping the sections
  • new troubleshooting section that contains debugging options: skip validation, form reset on submit, output log.
  • new fallback email fields for all integrations, this will send an email with all details if there is and issue with integration.

Changed

  • all JS global variables for frontend and backend are now using the same name.
  • internal custom field for actions is now called es-form-action.
  • filter for setting http request from httpRequestArgs to httpRequestTimeout because it is used only to set timeout.
  • Greenhouse integration from wp_remote_post to regular Curl because of the issues while sending the attachments. You are now no longer limited on the amount of memory on your server to send files.
  • Form will now throw and error if form ID or type is missing in the request.
  • all remote requests now output via helper for easier and more predictable output.

Fixed

  • all text domains that were wrong changed from eightshift-form to eightshift-forms.
  • Active campaign body was set wrong and was not working.
  • Active campaign setting info copy for setting api key and url.
  • customSuccess label is now translatable from settings.
  • validator will now skip input type hidden because there is no need for that.

Removed

  • ES_DEVELOP_MODE_SKIP_VALIDATION because it is used from admin now.
  • ES_LOG_MODE because it is used from admin now.

Screenshots

Screenshot 2022-09-05 at 15 41 24
Screenshot 2022-09-05 at 15 42 18
Screenshot 2022-09-02 at 15 13 09
Screenshot 2022-09-02 at 15 13 13

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working improvement Small improvement fixes, either readability or performance improvements integrations Issues with integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify the code Issue with JS loading and localized scripts

6 participants